Reduce WC_RNG allocations in WolfCryptCipher and WolfCryptDhParameterGenerator#208
Merged
rlm2002 merged 3 commits intowolfSSL:masterfrom Apr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes the wolfJCE provider’s native RNG usage by avoiding unnecessary WC_RNG allocations in code paths that don’t require randomness, and by reusing a single RNG across DH parameter-generation retries.
Changes:
- Defer
Rngcreation inWolfCryptCipheruntil RSA code paths actually need it, rather than allocating for every cipher instance. - Reuse a single
RngacrossPRIME_GEN_Eretry attempts inWolfCryptDhParameterGeneratorinstead of allocating/freeing per attempt. - Ensure RNG cleanup is performed during
WolfCryptCipher.finalize().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/com/wolfssl/provider/jce/WolfCryptDhParameterGenerator.java | Moves RNG initialization outside the prime-generation retry loop to reuse one native RNG across attempts. |
| src/main/java/com/wolfssl/provider/jce/WolfCryptCipher.java | Makes RNG allocation lazy for RSA-only usage and adjusts finalization cleanup for RNG resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rlm2002
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes a few optimizations to reduce creation of
WC_RNGstructs when not needed.rng.free()call infinalize()for cleanup consistency.PRIME_GEN_Eretry loop so a single WC_RNG is reused across retries instead of creating and destroying one per attempt.